Skip to content

[ALICE3] Add strangeness tof pid to a3 cascade finding#16987

Merged
njacazio merged 4 commits into
AliceO2Group:masterfrom
jesgum:a3stra-pid
Jul 14, 2026
Merged

[ALICE3] Add strangeness tof pid to a3 cascade finding#16987
njacazio merged 4 commits into
AliceO2Group:masterfrom
jesgum:a3stra-pid

Conversation

@jesgum

@jesgum jesgum commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot changed the title Add strangeness tof pid to a3 cascade finding [ALICE3] Add strangeness tof pid to a3 cascade finding Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 1 errors, ⚠️ 0 warnings, 🔕 0 disabled

@jesgum jesgum marked this pull request as ready for review July 14, 2026 07:23
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 8c8fe21 at 2026-07-14 09:29:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 7 errors and 24 warnings.'
Found 7 errors and 24 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/fbb9193a2465de86b2cc0c9bb1d60bb2f8c21939/O2Physics-code-check/errors.txt
ALICE3/TableProducer/alice3StrangenessTofPid.cxx:47:86: error: no header providing "o2::aod::TracksDCA" is directly included [misc-include-cleaner,-warnings-as-errors]
ALICE3/Tasks/alice3Strangeness.cxx:60:8: error: constructor does not initialize these fields: appliedSelectionCheckMask, selectionCheck, selectionCheckPos [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
ALICE3/Tasks/alice3Strangeness.cxx:171:13: error: member 'posDaugDCAselIDx' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
ALICE3/Tasks/alice3Strangeness.cxx:172:20: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
ALICE3/Tasks/alice3Strangeness.cxx:216:11: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
ALICE3/Utils/a3StrangenessTofPidHelper.h:23:1: error: included header TrackParametrizationWithError.h is not used directly [misc-include-cleaner,-warnings-as-errors]
ALICE3/Utils/a3StrangenessTofPidHelper.h:152:56: error: no header providing "o2::track::TrackParCov" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 24 -gt 0 ]]
++ cat /sw/BUILD/fbb9193a2465de86b2cc0c9bb1d60bb2f8c21939/O2Physics-code-check/warnings.txt
ALICE3/Tasks/alice3Strangeness.cxx:424:91: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:427:91: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:430:78: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:433:69: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:436:158: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:470:78: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:472:103: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:477:84: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:484:63: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:492:87: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:500:65: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:508:89: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:514:119: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:516:123: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:520:124: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:525:166: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:527:190: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:530:18: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:532:13: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:539:148: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:551:40: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:553:22: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:555:26: warning: statement should be inside braces [readability-braces-around-statements]
ALICE3/Tasks/alice3Strangeness.cxx:557:30: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 7 -gt 0 ]]
++ exit 1
--

Full log here.

@njacazio njacazio merged commit 79874c2 into AliceO2Group:master Jul 14, 2026
11 of 15 checks passed
@jesgum jesgum deleted the a3stra-pid branch July 14, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants