Skip to content

[PWGJE] Fix join mistakes and other issues in jetShape.cxx#17082

Open
ynishida-style wants to merge 2 commits into
AliceO2Group:masterfrom
ynishida-style:master
Open

[PWGJE] Fix join mistakes and other issues in jetShape.cxx#17082
ynishida-style wants to merge 2 commits into
AliceO2Group:masterfrom
ynishida-style:master

Conversation

@ynishida-style

Copy link
Copy Markdown
Contributor

Apply the following fixes and updates for jetShape.cxx:
・Fix incorrect table joins and related issues
・Disable the rho_estimator when analyzing pp collisions
・Add a centrality axis to the jet count histogram

@github-actions github-actions Bot added the pwgje label Jul 16, 2026
@github-actions github-actions Bot changed the title Fix join mistakes and other issues for jetShape.cxx [PWGJE] Fix join mistakes and other issues for jetShape.cxx Jul 16, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 94e405b at 2026-07-16 06:08:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGJE/Tasks/jetShape.cxx:1276:18: error: unused variable 'isMaterial' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 94e405b at 2026-07-16 06:47:

## sw/BUILD/O2Physics-latest/log
2026-07-16T06:44:41.467+0200 [4703:140237183884928] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:44:41.467+0200 [4703:140237183884928] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-07-16T06:45:01.469+0200 [4703:140237183884928] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:44:41.733+0200 [4724:140244356345472] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:44:41.734+0200 [4724:140244356345472] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-07-16T06:45:01.735+0200 [4724:140244356345472] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:44:37.068+0200 [4603:140437778910848] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:44:37.075+0200 [4603:140437778910848] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-07-16T06:45:37.073+0200 [4603:140437778910848] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:44:37.557+0200 [4646:140228442074752] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:44:37.557+0200 [4646:140228442074752] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-07-16T06:45:37.561+0200 [4646:140228442074752] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:45:22.118+0200 [4768:139970663419520] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:45:22.118+0200 [4768:139970663419520] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-07-16T06:45:42.119+0200 [4768:139970663419520] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:45:22.387+0200 [4789:140577235050112] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:45:22.387+0200 [4789:140577235050112] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-07-16T06:45:42.389+0200 [4789:140577235050112] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:44:37.085+0200 [4602:140470880366208] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:44:37.085+0200 [4602:140470880366208] [executioncontext.cpp:544] [ERROR] Error while querying action cache at "http://localhost:8980": 14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame
2026-07-16T06:45:57.091+0200 [4602:140470880366208] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: connection attempt timed out before receiving SETTINGS frame]
2026-07-16T06:46:00.648+0200 [3806:140497561198208] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.649+0200 [4426:140127388282496] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.651+0200 [4426:140127388282496] [executioncontext.cpp:739] [ERROR] Failed to download output blob 5ab5aeecf8207752450eb5cd7388f41f4bcc3196a4df26ee54d44f433c6c2510: 14: Socket closed
2026-07-16T06:46:00.648+0200 [4403:139697312575104] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.650+0200 [4403:139697312575104] [executioncontext.cpp:739] [ERROR] Failed to download output blob 9589dbf3ca17f944d4773909ace7dc9cdee1bea7deb94e4ba28370837fbc869a: 14: Socket closed
2026-07-16T06:46:00.649+0200 [4528:140187237711488] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.651+0200 [4528:140187237711488] [executioncontext.cpp:739] [ERROR] Failed to download output blob 568f5b0403360523f0ff24a3e460047b3a0dbb31acc90c3f37e0d745a7b65468: 14: Socket closed
2026-07-16T06:46:00.649+0200 [4452:140345945091712] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.650+0200 [4452:140345945091712] [executioncontext.cpp:739] [ERROR] Failed to download output blob 32ba39dcea211e9b4e1263e7a644f2b21238e2c7ab0396905a91b27037f6292d: 14: Socket closed
2026-07-16T06:46:00.649+0200 [4456:139740536401536] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.651+0200 [4456:139740536401536] [executioncontext.cpp:739] [ERROR] Failed to download output blob 5cda44cac833c06d8a219a785777c7e69f8a8d6944d5638ecfbee1849abea6cf: 14: Socket closed
2026-07-16T06:46:00.649+0200 [4123:140480619327104] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.653+0200 [4123:140480619327104] [executioncontext.cpp:739] [ERROR] Failed to download output blob aaa8607ec4697529aeb22ccf12df42f5e89230a779289b24c86410e103e806db: 14: Socket closed
2026-07-16T06:46:00.648+0200 [4337:139672705236608] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.651+0200 [4337:139672705236608] [executioncontext.cpp:739] [ERROR] Failed to download output blob 35c5b3370bcccd4b368003a41152e2db87b8373c2ce75118fac808fc514e72e4: 14: Socket closed
2026-07-16T06:46:00.649+0200 [4381:140579725528704] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.652+0200 [4381:140579725528704] [executioncontext.cpp:739] [ERROR] Failed to download output blob e437fd603c3a2350b0684812c293cc9dec51599d5ee83ca91661465619b38f73: 14: Socket closed
2026-07-16T06:46:00.649+0200 [4502:140260629814912] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.651+0200 [4502:140260629814912] [executioncontext.cpp:739] [ERROR] Failed to download output blob 13606e79efc6dde4164c55a6b149a5ba98d62564650584ab916d0994f5c393d1: 14: Socket closed
2026-07-16T06:46:00.648+0200 [4197:139828285025920] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.656+0200 [4197:139828285025920] [executioncontext.cpp:739] [ERROR] Failed to download output blob 8e009f7c8f8237c9ef9f8f96f8dae0634fdc2d8408c466c4f9c5d6612a815d02: 14: Socket closed
2026-07-16T06:46:00.649+0200 [4555:139761832795776] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.650+0200 [4555:139761832795776] [executioncontext.cpp:739] [ERROR] Failed to download output blob 3b8fb54b8a042b1f61a14faa02a79b8d9d5b8ced96e924e018416b4b1608b119: 14: Socket closed
2026-07-16T06:46:00.649+0200 [4359:140353694289536] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.652+0200 [4359:140353694289536] [executioncontext.cpp:739] [ERROR] Failed to download output blob 2a481114c5b4488a413c1da190527921ccb72b59f70d30e3ecae1c17a5007d71: 14: Socket closed
2026-07-16T06:46:00.649+0200 [4075:139900493303424] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-16T06:46:00.656+0200 [4075:139900493303424] [executioncontext.cpp:739] [ERROR] Failed to download output blob f01fa4d27ce2f3752f6e4a964771e86fe83f5f80cfff6b67bb952af2caf19c69: 14: Socket closed
[0 more errors; see full log]

Full log here.

@ynishida-style ynishida-style changed the title [PWGJE] Fix join mistakes and other issues for jetShape.cxx [PWGJE] Fix join mistakes and other issues in jetShape.cxx Jul 16, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 37a73fa at 2026-07-16 07:33:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 1 warnings.'
Found 1 errors and 1 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/fa30d073794c2dc75afd262602704879b87a93bf/O2Physics-code-check/errors.txt
PWGJE/Tasks/jetShape.cxx:1122:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/fa30d073794c2dc75afd262602704879b87a93bf/O2Physics-code-check/warnings.txt
PWGJE/Tasks/jetShape.cxx:651:42: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 94e405b at 2026-07-16 08:22:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 3 errors and 1 warnings.'
Found 3 errors and 1 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/3e3507259ade70f47ab07229b682d03b2880bd7e/O2Physics-code-check/errors.txt
PWGJE/Tasks/jetShape.cxx:1122:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGJE/Tasks/jetShape.cxx:1276:18: error: Value stored to 'isMaterial' during its initialization is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGJE/Tasks/jetShape.cxx:1276:18: error: unused variable 'isMaterial' [clang-diagnostic-unused-variable,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/3e3507259ade70f47ab07229b682d03b2880bd7e/O2Physics-code-check/warnings.txt
PWGJE/Tasks/jetShape.cxx:651:42: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants