opencc: enable jieba segmentation plugin#291396
Open
frankslin wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
autosquash
OpenCC has shipped `BUILD_OPENCC_JIEBA_PLUGIN` since ver.1.3.0. When enabled, the build produces libopencc-jieba as a loadable plugin that replaces the default mmseg segmenter with cppjieba for configs such as s2twp_jieba.json, yielding more accurate phrase-boundary detection on Simplified Chinese input. The tradeoff is roughly 18 MB of additional installed data under `share/opencc/jieba_dict/` (merged trie, HMM model, IDF weights, and raw dictionary files). No new formula dependency is required; cppjieba is bundled in the OpenCC source tree and licensed under MIT.
github-actions
Bot
removed
the
autosquash
frankslin
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b9395292e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCC has shipped
BUILD_OPENCC_JIEBA_PLUGINsince ver.1.3.0. When enabled, the build produceslibopencc-jiebaas a loadable plugin that replaces the default mmseg segmenter with cppjieba for configs such ass2twp_jieba.json, yielding more accurate phrase-boundary detection on Simplified Chinese input.The tradeoff is roughly 18 MB of additional installed data under
share/opencc/jieba_dict/(merged trie, HMM model, IDF weights, and raw dictionary files). No new formula dependency is required; cppjieba is bundled in the OpenCC source tree and licensed under MIT.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?I used Claude Code to draft this PR and I did a round of manual check and revision to the diff.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source openccto confirm the plugin compiles and installs correctly, and the CLI functions correctlybrew test openccto confirm both the existing s2t test and the new jieba test (城堡里的士兵 → 城堡裡的士兵) passbrew audit --strict openccandbrew style openccwith all offenses addressed, now no offences detectedlib/opencc/plugins/libopencc-jieba.dylibis present in the installed prefix