Skip to content

feat(settings): gate custom images with feature flag#3414

Merged
tatoalo merged 1 commit into
mainfrom
posthog-code/gate-custom-images-settings
Jul 14, 2026
Merged

feat(settings): gate custom images with feature flag#3414
tatoalo merged 1 commit into
mainfrom
posthog-code/gate-custom-images-settings

Conversation

@tatoalo

@tatoalo tatoalo commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Problem

Custom sandbox image controls are discovered only through the API response. PostHog Code should use the existing rollout flag directly so the settings and task UI expose custom images only to enabled users

@tatoalo tatoalo self-assigned this Jul 14, 2026
@trunk-io

trunk-io Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

😎 Merged manually by @tatoalo - details.

@github-actions

github-actions Bot commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit 49036ff.

@tatoalo tatoalo added the Stamphog This will request an autostamp by stamphog on small changes label Jul 14, 2026
@tatoalo tatoalo marked this pull request as ready for review July 14, 2026 09:35
github-actions[bot]
github-actions Bot previously approved these changes Jul 14, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial UI hook change that gates an existing query behind a feature flag. No showstoppers — additive and safe.

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Reviews (1): Last reviewed commit: "feat(settings): gate custom images with ..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Jul 14, 2026
View reviewed changes
Comment thread packages/ui/src/features/settings/sections/environments/useSandboxCustomImages.ts Outdated
@tatoalo tatoalo force-pushed the posthog-code/gate-custom-images-settings branch from 4e8dd43 to 0da5856 Compare July 14, 2026 09:45
@github-actions github-actions Bot dismissed their stale review July 14, 2026 09:45

New commits pushed (delta classified non_trivial_delta) — stamphog approval dismissed; re-review running automatically.

stamphog[bot]
stamphog Bot reviewed Jul 14, 2026
View reviewed changes

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review agent couldn't reach its LLM backend — an infrastructure or credentials issue, not a problem with this PR. The Stamphog label has been kept; the review retries automatically on the next push, or re-apply the label once the backend recovers.

github-actions[bot]
github-actions Bot previously approved these changes Jul 14, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small additive change gating a query behind a feature flag. The previously flagged data-loss risk (flag returning false during load causing image deletion) was addressed: customImagesEnabled now requires both the flag and data, while customImagesDisabled remains tied to an explicit server error — so no silent image removal on cold load.

@stamphog

stamphog Bot commented Jul 14, 2026

Copy link
Copy Markdown

Retaining stamphog approval — delta since last review classified as trivial_paths.

@tatoalo
feat(settings): gate custom images with feature flag
49036ff 
Generated-By: PostHog Code
Task-Id: bf2043a7-7d19-4dac-9d50-c0f1780de97a

fix(settings): preserve custom image while flags load

Generated-By: PostHog Code
Task-Id: bf2043a7-7d19-4dac-9d50-c0f1780de97a

test(harness): avoid OAuth callback port collisions

Generated-By: PostHog Code
Task-Id: bf2043a7-7d19-4dac-9d50-c0f1780de97a
@tatoalo tatoalo force-pushed the posthog-code/gate-custom-images-settings branch from 02b0b4d to 49036ff Compare July 14, 2026 10:10
@github-actions github-actions Bot dismissed their stale review July 14, 2026 10:11

New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.

stamphog[bot]
stamphog Bot reviewed Jul 14, 2026
View reviewed changes

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are low-risk (test reliability fix + feature flag gating with correct loading-state handling), but the deny-list flagged auth-related files and this is classified T2-never, requiring human review before auto-approval.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jul 14, 2026
@tatoalo tatoalo merged commit 215e2c0 into main Jul 14, 2026
26 checks passed
@tatoalo tatoalo deleted the posthog-code/gate-custom-images-settings branch July 14, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@stamphog stamphog[bot] stamphog[bot] left review comments
@skoob13 skoob13 skoob13 approved these changes
@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@tatoalo tatoalo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tatoalo @skoob13