ConstraintAnalysis: Fix Pops and non-nullable LocalSets#8895
Merged
Conversation
tlively
reviewed
Jul 10, 2026
Comment on lines
+3503
to
+3504
| ;; internal errors, and we can just optimize this to unreachable (though we | ||
| ;; keep the local.set, because of non-nullable local validation). |
Member
There was a problem hiding this comment.
I see the unreachable that was appended, but where are the dropped children? And what's the connection to non-nullable local validation here? The i32 local is not non-nullable.
Member
Author
There was a problem hiding this comment.
getDroppedChildren handles effects in pops and local.set etc., by keeping them around if necessary, with their children.
Good point that it might not need to do so for locals that are not non-nullable. But it isn't important to optimize that here, I think - other passes will.
Member
Author
There was a problem hiding this comment.
(getDroppedChildren has a flag, the last parameter, that controls whether to ignore parent effects or not. Here we use the default, which does not ignore them)
tlively
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot just remove such IR, even if unreachable. Use
getDroppedChildrenAndAppendand also run EH fixups.