Script Loader: Trigger _doing_it_wrong() when wp_set_script_translations() is called before script registration#12475
Conversation
…fore script registration
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This PR updates
wp_set_script_translations()to trigger_doing_it_wrong()when it is called for a script that has not yet been registered.Previously, the function silently failed because
WP_Scripts::set_translations()returnedfalse, making it difficult for developers to identify incorrect usage.Trac ticket: https://core.trac.wordpress.org/ticket/50749
Use of AI Tools
AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5.1
Used for: Initial code skeleton; final implementation was edited by me.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.