fix(serve): dedicated INFERENCE_RECOMMENDER telemetry feature + type workload param#6028
Open
ZealSV wants to merge 1 commit into
Open
fix(serve): dedicated INFERENCE_RECOMMENDER telemetry feature + type workload param#6028ZealSV wants to merge 1 commit into
ZealSV wants to merge 1 commit into
Conversation
…workload param Address review nits on the AI inference recommender: - Add Feature.INFERENCE_RECOMMENDER telemetry enum + FEATURE_TO_CODE mapping; tag generate_deployment_recommendations, start_benchmark, and show_result with it instead of MODEL_CUSTOMIZATION. - Type generate_deployment_recommendations(workload=...) as Optional[Union[Workload, str]] to match the other params.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address review nits on the AI inference recommender:
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.