ENT-10199: Fixed a bug regarding the resolution of namespaces inside function-calls#6213
ENT-10199: Fixed a bug regarding the resolution of namespaces inside function-calls#6213SimonThalvorsen wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14098/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14098/ |
|
In your commit message I think it would be nice to enumerate the functions for which this is now fixed. |
Also, functions is a bit vague, i assume it means policy functions (not internal C functions). |
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Please look into the NULL scope / bundle, and also improve the changelog entry.
SimonThalvorsen
changed the title
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
I am still missing an enuymerated list of policy functions that are affected by the change. I see in your comments read_module_protocal() but I think we should surface the specific list.
I changed the wording since as far as I could tell, it would affect all cases of expanding args inside a call, tested it with other functions also referencing variables in other bundles in the same non-default namespace and they all got the same issue without the fix, so rather than enumerating all functions I tried making the changelog-message more generic. But it may need some work to get this across more easily |
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Please add a policy acceptance test. In my eyes the fix looks a bit "weird", like maybe this logic should be inside the expand function(?)
SimonThalvorsen
force-pushed
the
master
branch
2 times, most recently
from
06db52d to
2a5a12c
Compare
SimonThalvorsen
force-pushed
the
master
branch
3 times, most recently
from
868b6a9 to
9029771
Compare
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Please use cfengine format to format the test
SimonThalvorsen
force-pushed
the
master
branch
2 times, most recently
from
b882aa1 to
0f1f63c
Compare
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14185/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14185/ |
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14188/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14188/ |
SimonThalvorsen
force-pushed
the
master
branch
2 times, most recently
from
5d10c3c to
8acec83
Compare
…function-calls Ticket: ENT-10199 Changelog: Title Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14204/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14204/ |
6 participants
Ticket: ENT-10199
Changelog: Title