Refresh coderabbit-review skill: fix timeout/retry guidance, match current CLI contract#6
Draft
nehal-a2z wants to merge 1 commit into
Draft
Refresh coderabbit-review skill: fix timeout/retry guidance, match current CLI contract#6nehal-a2z wants to merge 1 commit into
nehal-a2z wants to merge 1 commit into
Conversation
…rrent CLI contract Incident-driven fixes: - Replace the 10-minute wait window (which was killing the slowest 15-25% of reviews at exactly 600s) with a >=1800s exec/tool timeout or background execution; reviews can take up to 30 minutes. - Guardrail: never blind-rerun after a timeout/disconnect (the server review keeps running and each rerun burns rate limit); retry at most once per session. - Guardrail: at most one review per machine; no parallel sub-agent reviews (clientId is machine-scoped, concurrent runs corrupt each other's delivery state). - Recommend scoped reviews (-t uncommitted / --base / --dir) over full reviews by default. Staleness refresh against apps/cli (mono): - Document the real agent NDJSON contract: review_context / status / heartbeat (45s) / finding / complete / error; finding carries fileName but no line numbers; completion is a complete event with a findings count. - Severity order extended to critical, major, minor, trivial, info. - Note -t accepts all (default) besides committed/uncommitted; add --dir scoping; -c is variadic. Bump plugin version 1.1.1 -> 1.2.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes
plugins/coderabbit/skills/coderabbit-review/SKILL.mdto stop the skill from causing review failures, and re-audits every factual claim in it against the current CLI source (apps/cliin the mono repo, as of 2026-07-15).Why (incident data, Jul 15 2026)
code_review_fail: extension_emitter_missingaccelerated 1.2k → 4.1k/day. Fail times spike sharply at exactly 600s — this skill's own "10-minute window" is killingcoderabbit reviewmid-run. The server review is fire-and-forget over one WebSocket and cannot survive any disconnect.Behavior changes
heartbeatNDJSON events (every 45s) instead of a wall-clock silence budget.coderabbit review; retry at most once per session; report persistent failures to the user.coderabbit reviewper machine; never launch reviews from parallel sub-agents.-t uncommitted/--base <branch>/--dir <path>over full reviews; full review only when the user asks for everything.Also bumps
plugin.json1.1.1 → 1.2.0 (repo convention: substantive skill changes bump the version, cf. the 1.1.1 bump commit).Stale claims corrected (audited against
apps/cli)const timeoutMs = 60 * 60 * 1000); completed reviews run p50 ~4.5 min / p90 ~12 min with a ~30 min server ceiling. 10 minutes was never a real limit — it was killing healthy reviewsapps/cli/src/services/review/review.ts:374finding/status/errorreview_context,status,heartbeat,finding,complete,error(discriminator fieldtype)apps/cli/src/commands/review/run/execute.ts:65-92,apps/cli/src/commands/review/run/agent-review-context-event.ts:1-8heartbeatevent every 45s (AGENT_HEARTBEAT_INTERVAL_MS = 45_000) — usable as a liveness signalapps/cli/src/commands/review/run/execute.ts:119-120completeevent carryingstatus: "review_completed"|"review_skipped"and afindingscountapps/cli/src/commands/review/run/execute.ts:77-83finding={type, severity, fileName, codegenInstructions, suggestions[, comment]}—commentonly whencodegenInstructionsis empty; no line numbers on the wireapps/cli/src/commands/review/run/format.ts:70-83critical, major, minor, trivial, info(severity union also includesnone, excluded from counts)apps/cli/src/commands/review/run/execute.ts:110-116,pr-reviewer-saas/src/review/parse-review.ts:31-37-t committed/-t uncommittedshown; default unstated-t, --type <type>accepts exactlyall(default),committed,uncommittedapps/cli/src/program.ts:121-125,apps/cli/src/types/review-state.ts:41--dir <path>reviews only git changes inside a directory — added, since scoped reviews are now the recommendationapps/cli/src/program.ts:135-cshown with single-file phrasing-c, --config <files...>is variadic (multiple files in one flag)apps/cli/src/program.ts:126-129Verified still correct (no change)
curl -fsSL https://cli.coderabbit.ai/install.sh | sh—apps/cli/install.sh:10coderabbit --version—apps/cli/src/program.ts:87coderabbit auth status --agent/coderabbit auth login --agent—apps/cli/src/commands/auth.ts:29-135--base <branch>/--base-commit <commit>—apps/cli/src/program.ts:130-134Deliberately not added
--light: the flag exists (apps/cli/src/program.ts:115) but its server-side effect is gated per-user behind thecli_review_policy_flagPostHog flag (pr-reviewer-saas/src/event-client/cli-review-policy.ts:161-174— flag off silently falls back to the default policy), so it is not recommendable as generally available.--plain/--fast/--interactive/--cwd/--prompt-only: all removed from the CLI (mono #21906, 2026-07-13; the dead "plain" mode concept cleaned up in #21249). The skill did not mention them before and still does not.🤖 Generated with Claude Code