Skip to content

feat: keep canvas designs editable via the image library #500

Open
bhavjsh wants to merge 3 commits into
fossasia:mainfrom
bhavjsh:feature/editable-canvas-persistence
Open

feat: keep canvas designs editable via the image library #500
bhavjsh wants to merge 3 commits into
fossasia:mainfrom
bhavjsh:feature/editable-canvas-persistence

Conversation

@bhavjsh

@bhavjsh bhavjsh commented Jul 5, 2026

Copy link
Copy Markdown
Member

Fixes #499

⚠️ Depends on #487 (merge that first)
Built directly on the canvas editor, so it can't compile without it.

Changes

  • Editor designs are now saved so you can edit them again later (not just as a flat image).
  • One save flow: canvas ✓ takes you to the filter screen, and its Save saves the e-paper (filtered) image
  • Image Library:
    • Edit reopens a design in the canvas, then the filter screen, and updates the same entry (no duplicate).
    • Change Filter reopens an image in the filter screen to re-pick its filter and transfer.
    • Plain imported images can be edited too, they open in the canvas as a single layer so you can add text/stickers.
  • Changing the filter starts from the original image, so filters don't stack on top of each other.
  • Reopening a badge brings back the same filter, flips, and display you saved.
  • Fixed the delete screen title getting cut off and made the Delete button cleaner.

Recording

edit.mp4

Checklist:

  • No hard coding: I have used values from constants.dart or localization files instead of hard-coded values.
  • No end of file edits: No modifications done at end of resource files.
  • Code reformatting: I have formatted the code using dart format or the IDE formatter.
  • Code analysis: My code passes checks run in flutter analyze and tests run in flutter test.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @bhavjsh, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@bhavjsh bhavjsh marked this pull request as draft July 5, 2026 13:18
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Build Status

Build successful. APKs to test: https://github.com/fossasia/magic-epaper-app/actions/runs/28860941212/artifacts/8135962095.

Screenshots

Android Screenshots
iPhone Screenshots
iPad Screenshots

@bhavjsh bhavjsh force-pushed the feature/editable-canvas-persistence branch from 65133c3 to 8cc4fbc Compare July 7, 2026 10:53
@bhavjsh bhavjsh force-pushed the feature/editable-canvas-persistence branch from 8cc4fbc to 23a5ff9 Compare July 7, 2026 10:56
@bhavjsh bhavjsh marked this pull request as ready for review July 7, 2026 10:56

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @bhavjsh, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make ePaper images editable

1 participant