fix(auth): return no matches, not raw ValueError, for a malformed URL#3437
Merged
Merged
Conversation
find_entries_for_url did (urlparse(url).hostname or "").lower() unguarded. a malformed authority (e.g. an unterminated ipv6 bracket "https://[::1") makes urlparse/hostname raise ValueError, so instead of the empty list the function already returns for a host-less url, a raw ValueError leaked out of the shared http client (build_request / open_url call this before any url validation). no auth entry can match such a url, so treat it like the host-less case and return no matches. added a regression test over an unterminated bracket and a bracketed non-ip host; confirmed it fails on the pre-fix code.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in find_entries_for_url where malformed URL authorities could cause urlparse(...).hostname to raise ValueError, leaking an exception from the shared HTTP client path. The fix makes malformed-host URLs behave like host-less URLs for auth matching (returning no matches).
Changes:
- Catch
ValueErrorwhen extracting/lowercasing the parsed hostname and return[]for malformed authorities. - Add a regression test covering an unterminated IPv6 bracket and a bracketed non-IP host.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/authentication/config.py |
Wrap hostname extraction in try/except ValueError and return no matches on malformed URLs. |
tests/test_authentication.py |
Add parametrized regression test ensuring malformed URLs return [] rather than raising. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3436
find_entries_for_urldid(urlparse(url).hostname or "").lower()unguarded. a malformed authority (unterminated ipv6 brackethttps://[::1, bracketed non-ip hosthttps://[not-an-ip]) makes urlparse/hostname raiseValueError, so a raw ValueError leaked instead of the empty list the function already returns for a host-less url. this is the first step of the shared http client (build_request/open_urlcall it before any url validation), so it can surface out of catalog/extension/preset fetches.fix: wrap the parse + hostname access; on
ValueErrorreturn no matches, exactly like the host-less case just below it (no auth entry can match a url with no usable host anyway).added a regression test (
test_malformed_url_returns_empty) over an unterminated bracket and a bracketed non-ip host. i confirmed it fails on the pre-fix code by stashing the source and re-running (raw ValueError leaks); the auth suite passes with the fix.same bug class as #3210 and the recent bundler/catalog validator fixes.