adjusted the hover line gap in right side line#1136
Conversation
Signed-off-by: karthik_51 <mandhalakarthikreddy@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adjusts the left handle position of the resizable component in _resizable.scss to a fractional pixel value (-5.3px). The review feedback correctly points out that using fractional pixels is a subpixel rendering anti-pattern that can cause inconsistent rendering across devices, and suggests reverting to an integer value.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| } | ||
| .resizable--right .resizable__handle { right: -5px; } | ||
| .resizable--left .resizable__handle { left: -5px; } | ||
| .resizable--left .resizable__handle { left: -5.3px; } |
There was a problem hiding this comment.
Using fractional pixel values like -5.3px is a subpixel rendering anti-pattern in CSS. Because browsers round fractional pixels differently depending on the device's pixel ratio (DPI/Retina screens) and the browser's rendering engine, this can lead to blurry rendering, inconsistent alignment, or 1px gaps across different devices and zoom levels.\n\nAdditionally, this introduces asymmetry between the left and right handles (-5px vs -5.3px). It is highly recommended to use integer pixel values (e.g., -5px or -6px) to ensure consistent, crisp rendering across all devices.
| .resizable--left .resizable__handle { left: -5.3px; } | |
| .resizable--left .resizable__handle { left: -5px; } |
|
@Bhumikagarggg and @Bharath314 could you please review it ?? |
|
Signed-off-by: karthik_51 <mandhalakarthikreddy@gmail.com>
|
Adjusted pixel size to integer as per suggestion. Could anyone please review it?? |
Bharath314
left a comment
Bharath314
left a comment
There was a problem hiding this comment.
I tested this on a wide variety of layouts and it works correctly. I don't see any regressions being introduced by this. LGTM! 🚀
|
Thank you for contributing to the Layer5 community! 🎉 \ \ |
4 participants
Notes for Reviewers
Fixes
Resolves #1135 – The right sidebar resize handle hover highlight did not align correctly with the sidebar border.
What Changed
Updated the left offset of the right resize handle to improve alignment:
Previously, the offset was:
The small adjustment ensures the hover highlight aligns precisely with the sidebar border.
Result
Screenshots
Right Sidebar (After Fix)
Left Sidebar (Reference)
Both sidebar resize handles now align with their respective borders as expected.