[Examples] Demo pre-built instance handlers + inspector coverage#390
Merged
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
The pinned inspector 0.17.2 predates the protocol version bump to 2025-11-25 (v0.6.0) and rejects the handshake with "Server's protocol version is not supported", failing every inspector snapshot test. 0.22.0 negotiates the current protocol; the full inspector suite passes against it (95 tests, 7 pre-existing skips). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Extends the combined-registration example with a third handler style: a pre-built object instance `[$instance, 'method']`, alongside the existing discovered and manual class-string handlers. PreconfiguredGreeter takes a scalar constructor argument neither the container-less `new $className()` fallback nor the auto-wiring container can build, so it can only be registered as an already-constructed instance — exercising the resolver path added in the parent branch. Adds an inspector snapshot case (tools/call instance_greeter) and updates the tools/list snapshot. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chr-hertel
force-pushed
the
demo/instance-handler-example
branch
from
959e0e1 to
d237769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #375 (now merged): demonstrates the pre-built instance handler form it added, and gives it functional (inspector snapshot) coverage.
What & why
#375 makes
->addTool([$instance, 'method'])work — a handler registered as an already-constructed object. This PR gives that feature a home in the examples and a functional test.The combined-registration example was the natural fit: it already showcases discovered and manual class-string handlers, so adding the pre-built instance form completes the trio.
Changes
examples/server/combined-registration/PreconfiguredGreeter.php— a handler whose constructor takes a scalarstring $greeting. Neither the container-lessnew $className()fallback nor the SDK's auto-wiringContainercan build it (built-in types are explicitly unresolvable), so it can only be registered as a pre-built instance — a crisp demonstration of exactly why the feature exists.server.php— registers it via->addTool([$preconfiguredGreeter, 'greet'], 'instance_greeter').tools/call instance_greetercase inHttpCombinedRegistrationTest, plus updatedtools/listsnapshot.docs/examples.mdand clarified the instance-handler form's purpose indocs/server-builder.md.Separate infra fix (commit
[Tests] Bump MCP Inspector to 0.22.0)The pinned MCP Inspector
0.17.2predates the2025-11-25protocol bump (v0.6.0) and rejects the handshake (Server's protocol version is not supported) — this currently errors every inspector snapshot test. Bumped to0.22.0, which negotiates the current protocol. Happy to split this into a standalone PR if preferred.Verification
0.22.0: 95 tests, 7 pre-existing skips, 0 failures.php-cs-fixerclean, PHPStan clean.🤖 Generated with Claude Code