feat(tui): stream slug/preset installs through the wizard pipeline#146
Merged
Conversation
`install <slug>` / `install <preset>` (RemoteConfig) applied through the linear "OpenBoot Installer / Step N" output while bare `install` used the full-screen wizard — the actual mismatch behind "this UI is still old". (The earlier #143 unified runSyncInstall, a *different* path — the saved sync-source flow — not this one.) ApplyContext is the same engine both paths already use; only the reporter differs. On a TTY, resolve the plan with the linear pre-flight prep (installer.PlanForConfig: checkDependencies + Plan), then apply it through wizard.RunPipeline with a chanReporter, so the section headers stream as pipeline phases exactly like the wizard. Non-TTY / --silent / --dry-run keep RunContext. - installer.PlanForConfig(cfg): the RunContext flow up to (not incl.) apply. - wizard.RunPipeline's run now receives an installer.Reporter; add wizard.PhasesForPlan to seed the sidebar from an InstallPlan. - runPipelineInstall wires it, mirroring the wizard's abort/reminder/save handling. Verified on a real `install <slug>` (tmux): shows the PIPELINE sidebar + streaming log, zero "Step N" output. Claude-Session: https://claude.ai/code/session_01HLoiSd2k9EJJ1HPjjDgUgo
2966b9a to
a96dd5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
install <slug>/install <preset>apply through the wizard's full-screen streaming pipeline instead of the linear "OpenBoot Installer / Step N" output — the real fix for "this UI is still old".Why?
install <slug>resolves to a RemoteConfig and applied throughinstaller.RunContext(linear). The earlier #143 unifiedrunSyncInstall— a different path (the saved sync-source flow), which slug installs don't take. So the slug UI stayed old.installer.ApplyContextis the same engine both the wizard and RunContext already use — only the reporter differs (ConsoleReporter vs the wizard's channel reporter). On a TTY we now resolve the plan with the linear pre-flight (installer.PlanForConfig:checkDependencies+Plan), then apply it viawizard.RunPipelinewith achanReporter. The installer's section headers ("Step 1: Git Configuration", "Step 4: Installation", …) already map to pipeline phases via the wizard'sheaderPhase, so it streams identically to the wizard.installer.PlanForConfig(cfg)— the RunContext flow up to (not including) apply.wizard.RunPipeline's run closure now receives aninstaller.Reporter;wizard.PhasesForPlanseeds the sidebar from anInstallPlan.runPipelineInstallwires it, mirroring the wizard's abort / screen-recording-reminder / save-sync-source handling.--silent/--dry-runkeepRunContext(linear) unchanged.Testing
go vet ./..., fullinternal/...suite,go test -race(wizard),make build— greenTestPhasesForPlanlocks the plan→sidebar mappinginstall <slug>in a tmux pty: renders the PIPELINE sidebar (✓ Git identity,✓ Homebrew 24/24,✓ Applications 18/18,⠋ Dotfiles, …) + streaming log; zero "Step N" / "OpenBoot Installer" outputScope
Covers every interactive TTY install that used RunContext — slug, preset, and file/RemoteConfig sources — so they all share the pipeline now. dry-run stays linear (shows what would happen).
Cross-repo checklist
openboot.dev? — NoNotes for reviewer
RunPipelinemachinery.https://claude.ai/code/session_01HLoiSd2k9EJJ1HPjjDgUgo