Add --distribution filter to container content list.#1443
Open
gerrod3 wants to merge 4 commits into
Open
Conversation
gerrod3
force-pushed
the
issue-2164-distribution-content-filter
branch
from
2d58f6b to
32a9791
Compare
Resolve the served repository version from a distribution so users can list tags and other content for an image without manual lookup steps. Co-authored-by: Cursor <cursoragent@cursor.com>
gerrod3
force-pushed
the
issue-2164-distribution-content-filter
branch
from
32a9791 to
0a58401
Compare
Switching between repository and repository_version must complete the clearing update before applying the new value to avoid API validation errors under non-blocking updates. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
mdellweg
reviewed
Jul 13, 2026
mdellweg
left a comment
mdellweg
left a comment
Member
There was a problem hiding this comment.
You should rebase and probably squash the last two commits.
Comment on lines
+62
to
+67
| if "/container-push/" in repository_href: | ||
| repo_ctx: PulpRepositoryContext = PulpContainerPushRepositoryContext( | ||
| pulp_ctx, pulp_href=repository_href | ||
| ) | ||
| else: | ||
| repo_ctx = PulpContainerRepositoryContext(pulp_ctx, pulp_href=repository_href) |
Member
There was a problem hiding this comment.
The common base class wouldn't let us do this, right?
| if version is not None: | ||
| if distribution["repository"]: | ||
| distribution_ctx.update(body={"repository": ""}, non_blocking=non_blocking) | ||
| distribution_ctx.update(body={"repository": ""}, non_blocking=False) |
Member
There was a problem hiding this comment.
Does the server still not allow to update these in one go?
Comment on lines
+74
to
+75
| if not distribution: | ||
| return |
Member
There was a problem hiding this comment.
How do you think about inverting the if here?
This currently looks like an if with only a disguised else branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve the served repository version from a distribution so users can list tags and other content for an image without manual lookup steps.
Ref: pulp/pulp_container#2164