fix: Patch scrollToIndex to scroll backwards#43
Merged
chiefcll merged 1 commit intoJul 11, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Row.scrollToIndex/Column.scrollToIndexalways scroll forward, even when the target index is behind the current one —selectedupdates but the container never scrolls back, leaving the selected child off-screen.Repro: a
Rowwithscroll="auto"and overflowing children, scrolled forward to some indexn; callrow.scrollToIndex(n - 1)→selectedbecomesn - 1but the row'sxdoesn't move.Root cause
scrollToIndexoverwritesthis.selectedand then calls the scroller without alastSelected:In
withScrolling, an undefinedlastSelectedmakes the move register as incrementing (isIncrementing = lastSelected === undefined || ...), so the next position is always computed in the forward direction and then clamped — moving backward, the clamp leaves the container where it was. Key navigation is unaffected becauseselectChildpasseslastSelectedthroughonSelectedChanged; only programmaticscrollToIndexcalls lose the direction.Fix
Capture the previous
selectedbefore overwriting it and pass it aslastSelected, sowithScrollingresolves direction the same way it does for key navigation:When the index is unchanged,
undefinedis still passed on purpose:withScrollingearly-returns onselected === lastSelected, and some callers usescrollToIndexwith the current index to force positioning (e.g. after layout) — this keeps that behaviour intact.Same fix applied to
Column.scrollToIndexwithscrollColumn.