Mark remote JDK toolchain config repositories reproducible#365
Open
dzbarsky wants to merge 1 commit into
Open
Conversation
Return repository metadata from _toolchain_config_impl so the generated remote JDK toolchain config repositories can use the repository contents cache. Guard repo_metadata for Bazel 7 and Bazel 8 compatibility.
hvadehra
requested changes
Jul 9, 2026
| # rules_java supports Bazel versions without repository_ctx.repo_metadata. | ||
| if hasattr(ctx, "repo_metadata"): | ||
| return ctx.repo_metadata(reproducible = True) | ||
|
|
Member
There was a problem hiding this comment.
Explicitly return None here to make buildifier happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_toolchain_configrepository rule creates the remote JDK*_toolchain_config_reporepositories from deterministicWORKSPACEandBUILD.bazelcontent. Returnrepo_metadata(reproducible = True)so Bazel can use the repository contents cache for these repositories, with ahasattrguard for Bazel versions that do not providerepository_ctx.repo_metadata.Validation:
@remotejdk21_macos_aarch64_toolchain_config_repo//:allbuildifier -mode=check toolchains/remote_java_repository.bzl