Skip to content

Mark remote JDK toolchain config repositories reproducible #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dzbarsky wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

Mark remote JDK toolchain config repositories reproducible #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions toolchains/remote_java_repository.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ def _toolchain_config_impl(ctx):
ctx.file("WORKSPACE", "workspace(name = \"{name}\")\n".format(name = ctx.name))
ctx.file("BUILD.bazel", ctx.attr.build_file)

# rules_java supports Bazel versions without repository_ctx.repo_metadata.
if hasattr(ctx, "repo_metadata"):
return ctx.repo_metadata(reproducible = True)

@hvadehra hvadehra Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly return None here to make buildifier happy

_toolchain_config = repository_rule(
local = True,
implementation = _toolchain_config_impl,
Expand Down